Thanks for opening a pull request!

Could you open an issue for this pull request on Github Issues?

https://github.com/apache/incubator-gluten/issues

Then could you also rename commit message and pull request title in the following format?

[GLUTEN-${ISSUES_ID}][COMPONENT]feat/fix: ${detailed message}

See also:

• Other pull requests

depends on #7002

cc @PHILO-HE @liujiayi771 thank you!

@JkSelf

@Yohahaha Can you confirm, there is a list for merging metric values https://github.com/Yohahaha/gluten/blob/f58163433b83453b772d76a158503bb1a77e28ad/gluten-data/src/main/scala/org/apache/gluten/metrics/MetricsUtil.scala#L129-L153 and whether we should append some code into that list.

@Yohahaha Can you confirm, there is a list for merging metric values https://github.com/Yohahaha/gluten/blob/f58163433b83453b772d76a158503bb1a77e28ad/gluten-data/src/main/scala/org/apache/gluten/metrics/MetricsUtil.scala#L129-L153 and whether we should append some code into that list.

I see, TableWriter count physicalWrittenBytes, writeIONanos, numWrittenFiles, but only numWrittenFiles is merged.

why we need merge those metrics?

Sorry, I am not aside a dev PC now, so I can't actually reason about the code, which looks too magical to me by the way.

But what's clear is only input and output metrics were being handled separately when the code was firstly written .

TableWriter count physicalWrittenBytes, writeIONanos, numWrittenFiles, but only numWrittenFiles is merged

After all, I think we should make these 4 metrics consistent. Either merge them all, or none of them. And seems to be safe to merge them all by taking the first look. cc @JkSelf

===== Performance report for TPCDS SF2000 with Velox backend, for reference only ====